fix: fetch next batch if event types are empty and cursor exists#17109
Merged
fix: fetch next batch if event types are empty and cursor exists#17109
Conversation
keithwillcode
added
core
dosubot
Bot
added
event-types
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/15/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (10/30/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/11/24)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
commented
Oct 15, 2024
Comment on lines
+63
to
+67
| while (eventTypes.length < limit && (currentCursor || isFetchingForFirstTime)) { | ||
| await fetchAndFilterEventTypes(); | ||
| isFetchingForFirstTime = false; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
fetch event types till eventTypes.length>=limit.
Udit-takkar
commented
Oct 15, 2024
| const eventTypes: MappedEventType[] = []; | ||
| let currentCursor = cursor; | ||
| let nextCursor: typeof cursor | undefined = undefined; | ||
| let isFetchingForFirstTime = true; |
Contributor
Author
There was a problem hiding this comment.
isFetchingForFirstTime is required to prevent infinite while loop when user doesn't have any event types
Contributor
E2E results are ready! |
sean-brydon
reviewed
Nov 11, 2024
…omGroup.handler.ts Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
zomars
approved these changes
Nov 13, 2024
zomars
added a commit
that referenced
this pull request
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Login in as enterprise@example.com
Check whether all event types are loaded