Skip to content

chore: add logs for debugging#17111

Merged
Udit-takkar merged 10 commits intomainfrom
chore/add-debug-logs
Oct 17, 2024
Merged

chore: add logs for debugging#17111
Udit-takkar merged 10 commits intomainfrom
chore/add-debug-logs

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Oct 15, 2024

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@graphite-app graphite-app bot requested a review from a team October 15, 2024 10:35
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Oct 15, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/15/24)

1 label was added to this PR based on Keith Williams's automation.

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 15, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:22pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 1:22pm

Comment on lines -115 to -119
if (shouldListUserEvents || !teamId) {
filteredEventTypes = filteredEventTypes.filter(
(evType) => evType.schedulingType !== SchedulingType.MANAGED
);
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this to prisma query

@Udit-takkar Udit-takkar added this to the v4.6 milestone Oct 15, 2024
joeauyeung
joeauyeung previously approved these changes Oct 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2024

E2E results are ready!

@Udit-takkar Udit-takkar marked this pull request as draft October 16, 2024 07:54
auto-merge was automatically disabled October 16, 2024 07:54

Pull request was converted to draft

{
where: {
teamId: null,
schedulingType: null,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will the Managed Event eventtypes show up?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed event type would still show up in the user personal event tab. When you create a managed event type it is created on team level with scheduling type "MANAGED" and on user level with scheduling type null

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were earlier filtering this after prisma query to prevent displaying two event types

@keithwillcode keithwillcode modified the milestones: v4.6, v4.7 Oct 16, 2024
Copy link
Copy Markdown
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants