Skip to content

fix: link is not rendering properly for SMS and WhatsApp workflows#17116

Merged
CarinaWolli merged 3 commits into
calcom:mainfrom
anikdhabal:workflow_link_issue
Oct 15, 2024
Merged

fix: link is not rendering properly for SMS and WhatsApp workflows#17116
CarinaWolli merged 3 commits into
calcom:mainfrom
anikdhabal:workflow_link_issue

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Oct 15, 2024

What does this PR do?

Before:-
Screenshot 2024-10-15 183456

After:-
Screenshot 2024-10-15 183342

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Oct 15, 2024
@graphite-app graphite-app Bot requested a review from a team October 15, 2024 12:52
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 15, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added workflows area: workflows, automations 🐛 bug Something isn't working labels Oct 15, 2024
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Oct 15, 2024
@anikdhabal anikdhabal changed the title fix: Not able to save link in workflow fix: link is not rendering properly for SMS and WhatsApp workflows Oct 15, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 15, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/15/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/15/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your changes but any idea why it jumps to the top after typing a link?
https://www.loom.com/share/d8eb4adb5c8f4c4c8fe8369c360e858b

@anikdhabal
Copy link
Copy Markdown
Contributor Author

Not related to your changes but any idea why it jumps to the top after typing a link?

Yeah, I also saw this when pasting a link. I will fix it in a follow-up PR

@CarinaWolli CarinaWolli enabled auto-merge (squash) October 15, 2024 14:37
@CarinaWolli CarinaWolli merged commit 1f42a15 into calcom:main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs ready-for-e2e workflows area: workflows, automations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants