fix: Embed - Do not reuse the modal on reopening it.#17171
Merged
Conversation
keithwillcode
added
core
dosubot
Bot
added
embed
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
anikdhabal
approved these changes
Oct 18, 2024
PeerRich
approved these changes
Oct 18, 2024
Contributor
E2E results are ready! |
Contributor
|
@hariombalhara the problem is that old instances aren't being properly cleaned up which leads to a memory leak. can you add a fix to properly dispose of closed instances which is the original issue? |
This was referenced Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't reuse the modal.
This behaviour though was intended long time back wasn't working for a long time and got recently fixed in #17016. So, reverting it with a reason now.