fix: added aria-label to prev and next month buttons#17198
Merged
anikdhabal merged 2 commits intoOct 20, 2024
Merged
Conversation
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
ui
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/20/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/20/24)1 label was added to this PR based on Keith Williams's automation. |
shivambhatia604
force-pushed
the
shivambhatia604/fix-accessibility-17185
branch
from
f51f286 to
b4007b4
Compare
anikdhabal
approved these changes
Oct 20, 2024
Contributor
E2E results are ready! |
This was referenced Oct 20, 2024
anikdhabal
added a commit
that referenced
this pull request
Oct 21, 2024
* refactor: make this localizable base on #17198 making the new copy localizable * Update common.json * Update common.json * Update common.json --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the accessibility issue with the previous and next buttons. Required aria-label tag has been added in the buttons.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Are there environment variables that should be set?
No new environment variables are needed for this test
What are the minimal test data to have?
Access the event booking form and interact with the previous and next month buttons to observe the behavior with a screen reader.
What is expected (happy path) to have (input and output)?
The screen readers should announce the labels when buttons are focused via tab.