feat: AvailabilitySettings atom toggle toasts#17216
Merged
supalarry merged 2 commits intoOct 21, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
platform
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/21/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/21/24)1 label was added to this PR based on Keith Williams's automation. |
| onBeforeUpdate, | ||
| allowDelete, | ||
| allowSetToDefault, | ||
| disableToasts, |
Contributor
There was a problem hiding this comment.
Would it be a good idea to set a default value of false here?
Contributor
Author
There was a problem hiding this comment.
It is optional parameter so its value is undefined and in the check it essentially results into false so no need.
Ryukemeister
approved these changes
Oct 21, 2024
Contributor
Ryukemeister
left a comment
Ryukemeister
left a comment
There was a problem hiding this comment.
Apart from that one lil suggestion looks good otherwise!
…abilitysettings-successerror
supalarry
deleted the
lauris/cal-4547-platform-atoms-disable-availabilitysettings-successerror
branch
Contributor
E2E results are ready! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear CAL-4547