Skip to content

fix: slots troubleshooter data#17217

Merged
Udit-takkar merged 3 commits into
mainfrom
fix-troubleshooter-data-slots
Oct 22, 2024
Merged

fix: slots troubleshooter data#17217
Udit-takkar merged 3 commits into
mainfrom
fix-troubleshooter-data-slots

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Oct 21, 2024

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix troubleshooter data slots". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hariombalhara hariombalhara changed the title Fix troubleshooter data slots fix: slots troubleshooter data Oct 21, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 0:13am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 0:13am

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 21, 2024
hariombalhara
hariombalhara commented Oct 21, 2024
View reviewed changes
Comment thread packages/trpc/server/routers/viewer/slots/util.ts
askedContactOwner: contactOwnerEmailFromInput,
// One that we used as per Routing
usedContactOwner: contactOwnerEmail,
routedHosts: routedHostsWithContactOwnerAndFixedHosts.map((host) => {
Copy link
Copy Markdown
Member Author

@hariombalhara hariombalhara Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the correct variable. usersWithCredentials is the users we consider for slots.

@graphite-app graphite-app Bot requested a review from a team October 21, 2024 09:49
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024 •
edited
Loading

E2E results are ready!

@hariombalhara hariombalhara force-pushed the fix-troubleshooter-data-slots branch from a346411 to 56aa1d0 Compare October 22, 2024 10:13
@hariombalhara hariombalhara added the Urgent Created by Linear-GitHub Sync label Oct 22, 2024
@hariombalhara
Copy link
Copy Markdown
Member Author

hariombalhara commented Oct 22, 2024

Added urgent as it adds important data that is useful for debugging.

@Udit-takkar Udit-takkar enabled auto-merge (squash) October 22, 2024 12:13
@Udit-takkar Udit-takkar merged commit 1fc376c into main Oct 22, 2024
@Udit-takkar Udit-takkar deleted the fix-troubleshooter-data-slots branch October 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees

No one assigned

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e Urgent Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @Udit-takkar @keithwillcode