Skip to content

fix: platform event-type atom team delete#17225

Merged
ThyMinimalDev merged 3 commits into
mainfrom
fix-platform-event-type-atom-team-delete
Oct 21, 2024
Merged

fix: platform event-type atom team delete#17225
ThyMinimalDev merged 3 commits into
mainfrom
fix-platform-event-type-atom-team-delete

Conversation

@ThyMinimalDev
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev commented Oct 21, 2024 •
edited
Loading

What does this PR do?

Trying to delete a team event-type with atom was using the endpoint to delete non team event-types

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A- I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 21, 2024 3:36pm
calcom-web-canary ⬜️ Ignored (Inspect) Oct 21, 2024 3:36pm

@dosubot dosubot Bot added event-types area: event types, event-types platform Anything related to our platform plan teams area: teams, round robin, collective, managed event-types labels Oct 21, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 21, 2024
@graphite-app graphite-app Bot requested a review from a team October 21, 2024 14:46
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 21, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/21/24)

1 label was added to this PR based on Keith Williams's automation.

supalarry
supalarry reviewed Oct 21, 2024
View reviewed changes
Comment thread packages/platform/atoms/event-types/wrappers/EventTypePlatformWrapper.tsx
Comment thread packages/platform/atoms/hooks/event-types/private/useDeleteTeamEventTypeById.ts Outdated
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) October 21, 2024 15:43
@ThyMinimalDev ThyMinimalDev merged commit 9087f53 into main Oct 21, 2024
@ThyMinimalDev ThyMinimalDev deleted the fix-platform-event-type-atom-team-delete branch October 21, 2024 16:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supalarry supalarry supalarry approved these changes

@ibex088 ibex088 Awaiting requested review from ibex088

@Ryukemeister Ryukemeister Awaiting requested review from Ryukemeister

Assignees

No one assigned

Labels

core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThyMinimalDev @supalarry @keithwillcode