Skip to content

chore: Do not generate pages per language at build time#17227

Merged
emrysal merged 2 commits into
mainfrom
chore/do-not-include-pages-per-lang
Oct 22, 2024
Merged

chore: Do not generate pages per language at build time#17227
emrysal merged 2 commits into
mainfrom
chore/do-not-include-pages-per-lang

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Oct 21, 2024

What does this PR do?

  • Do not generate pages per language at build time

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go to /settings/my-account/general and change languages

@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 21, 2024
@graphite-app graphite-app Bot requested a review from a team October 21, 2024 17:21
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 21, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/21/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 6:58am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 6:58am

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK to me, I'll be sure to continue the i18n work in the wip branch but for now I don't anticipate problems with this.

@emrysal emrysal merged commit f22d585 into main Oct 22, 2024
@emrysal emrysal deleted the chore/do-not-include-pages-per-lang branch October 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants