Skip to content

feat: add more routing forms data#17229

Merged
zomars merged 8 commits into
mainfrom
feat/add-more-routing-forms-data
Oct 25, 2024
Merged

feat: add more routing forms data#17229
zomars merged 8 commits into
mainfrom
feat/add-more-routing-forms-data

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@zomars
Copy link
Copy Markdown
Contributor

zomars commented Oct 24, 2024

Taking over this PR

@zomars
Copy link
Copy Markdown
Contributor

zomars commented Oct 24, 2024

Fixed date formatting and replaced the user name with email as it might a be better identifier:

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 1:37am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 1:37am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 24, 2024

E2E results are ready!

Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. Tests are breaking. I underestimated the complexity here.

zomars
zomars previously approved these changes Oct 25, 2024
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a refactor using a presenter pattern to not mess with the buildResponsesForReporting tests and types.

@zomars zomars marked this pull request as ready for review October 25, 2024 00:54
@dosubot dosubot Bot added routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Oct 25, 2024
@graphite-app graphite-app Bot requested a review from a team October 25, 2024 00:55
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 25, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ✨ feature New feature or request foundation ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants