fix: booking.controller clone req to avoid side effect apiv2#17239
Merged
Conversation
dosubot
Bot
added
api
keithwillcode
added
core
supalarry
approved these changes
Oct 22, 2024
Contributor
supalarry
left a comment
supalarry
left a comment
There was a problem hiding this comment.
All good - in the newest bookings version we do this too.
Graphite Automations"Add platform team as reviewer" took an action on this PR • (10/22/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/22/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clonne Http Request in booking controller to avoid potential side effects and unexpected behaviours where req could be altered when it should not be.
Mandatory Tasks (DO NOT REMOVE)