fix: app store title#17307
Merged
Merged
Conversation
dosubot
Bot
added
app-store
hbjORbj
previously approved these changes
Oct 24, 2024
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (10/24/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hbjORbj
reviewed
Oct 24, 2024
| } & Omit<ComponentProps<typeof ShellMain>, "actions">; | ||
| } & Omit<ComponentProps<typeof Shell>, "actions">; | ||
|
|
||
| export default function AppsLayout({ children, actions, emptyStore, ...rest }: AppsLayoutProps) { |
Contributor
There was a problem hiding this comment.
there's no instance other than the one in apps-view
zomars
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app store title isn't working
I looked into it and the translation key exists:
And I can't quite figure out why the translations in the shell aren't working, so here's a low effort fix