fix: is Empty and is Not empty operators#17317
Merged
hariombalhara merged 1 commit intoOct 25, 2024
Merged
Conversation
keithwillcode
added
core
dosubot
Bot
added
routing-forms
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/25/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/25/24)1 label was added to this PR based on Keith Williams's automation. |
hariombalhara
commented
Oct 25, 2024
Comment on lines
+220
to
+240
| it("should allow fields with no value if valueSrc is empty", () => { | ||
| const result = queryValueSaveValidationSchema.safeParse({ | ||
| id: "7", | ||
| type: "group", | ||
| children1: { | ||
| rule1: { | ||
| type: "rule", | ||
| properties: { | ||
| field: "name", | ||
| operator: "is_empty", | ||
| value: [], | ||
| valueSrc: [], | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| expect(result.success).toBe(true); | ||
| }); | ||
|
|
||
| it("should not allow fields with no value if valueSrc is not empty", () => { | ||
| const result = queryValueSaveValidationSchema.safeParse({ |
Contributor
E2E results are ready! |
hariombalhara
deleted the
fix-is-empty-and-is-not-empty-operators-notbeing-saved
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Reported over intercom - User not able to save existing form which is using
is EmptyoperatorAfter Fix Loom
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
See loom