Skip to content

fix: 404s due to wrong booking link(without org domain)#17318

Merged
PeerRich merged 1 commit into
mainfrom
fix-org-domain
Oct 25, 2024
Merged

fix: 404s due to wrong booking link(without org domain)#17318
PeerRich merged 1 commit into
mainfrom
fix-org-domain

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Oct 25, 2024

What does this PR do?

Use eventType.bookerUrl which is org aware

Proof that the fix works

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 25, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Use bookerUrl in other links as well". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot Bot added the embed area: embed, widget, react embed label Oct 25, 2024
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 25, 2024
@graphite-app graphite-app Bot requested a review from a team October 25, 2024 06:58
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

@hariombalhara hariombalhara changed the title Use bookerUrl in other links as well fix: 404s due to wrong booking link(without org domain) Oct 25, 2024
@hariombalhara hariombalhara added Urgent Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync labels Oct 25, 2024
@PeerRich PeerRich enabled auto-merge (squash) October 25, 2024 07:56
@PeerRich PeerRich merged commit 9157e1f into main Oct 25, 2024
@PeerRich PeerRich deleted the fix-org-domain branch October 25, 2024 08:18
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only embed area: embed, widget, react embed enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e Urgent Created by Linear-GitHub Sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants