Skip to content

chore: Add search ability to the people filter within insights#17320

Merged
anikdhabal merged 2 commits intocalcom:mainfrom
anikdhabal:CAL-4598
Oct 25, 2024
Merged

chore: Add search ability to the people filter within insights#17320
anikdhabal merged 2 commits intocalcom:mainfrom
anikdhabal:CAL-4598

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Oct 25, 2024 •
edited
Loading

What does this PR do?

Screenshot 2024-10-25 163212

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@dosubot dosubot bot added insights area: insights, analytics 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Oct 25, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 25, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 25, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 25, 2024
@graphite-app graphite-app bot requested a review from a team October 25, 2024 11:16
@anikdhabal anikdhabal removed the community Created by Linear-GitHub Sync label Oct 25, 2024
anikdhabal
anikdhabal commented Oct 25, 2024
View reviewed changes
Comment thread packages/ui/components/popover/AnimatedPopover.tsx
) : (
<div className="max-w-36 flex items-center">
<Tooltip content={`${prefix}${text}`}>
<Tooltip content={prefix ? `${prefix}${text}` : text}>
Copy link
Copy Markdown
Contributor Author

@anikdhabal anikdhabal Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this

Screenshot 2024-10-25 164921

Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Oct 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

E2E results are ready!

hbjORbj
hbjORbj requested changes Oct 25, 2024
View reviewed changes
Comment thread packages/features/insights/filters/UsersListInTeam.tsx Outdated
@anikdhabal anikdhabal enabled auto-merge (squash) October 25, 2024 19:20
@anikdhabal anikdhabal mentioned this pull request Oct 25, 2024
Closed
@anikdhabal anikdhabal merged commit b6ce06b into calcom:main Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@sean-brydon sean-brydon Awaiting requested review from sean-brydon

Assignees

No one assigned

Labels

core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI insights area: insights, analytics ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anikdhabal @hbjORbj @keithwillcode