Skip to content

fix: give reason to reassign - allow team members to reassign even if busy#17328

Merged
zomars merged 9 commits intomainfrom
fix/rr-reassign-availability-members
Oct 25, 2024
Merged

fix: give reason to reassign - allow team members to reassign even if busy#17328
zomars merged 9 commits intomainfrom
fix/rr-reassign-availability-members

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Oct 25, 2024 •
edited by CarinaWolli
Loading

What does this PR do?

Loom: https://www.loom.com/share/0a0ae115863d46c0bc651756b5c10d50
Partially fixes CAL-4609 - will add reroute in another PR

Also adds reason and reassigned by to the email sent out

Emails:
New host:
Screenshot 2024-10-25 at 1 52 16 PM

previous host:
Screenshot 2024-10-25 at 1 52 41 PM

How should this be tested?

Test reassign as a member and a admin. Go to reassign to a busy member. Get a modal popup where you need to fill in a reason.

@linear
Copy link
Copy Markdown

linear bot commented Oct 25, 2024

CAL-4609 reasonReassign and reasonReroute

@github-actions github-actions bot added the ❗️ migrations contains migration files label Oct 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: give reason to reassign - allow team members to reassign even if busy". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the teams area: teams, round robin, collective, managed event-types label Oct 25, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 25, 2024
@graphite-app graphite-app bot requested a review from a team October 25, 2024 15:05
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Oct 25, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 6:54pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 6:54pm

@sean-brydon sean-brydon changed the title Fix: give reason to reassign - allow team members to reassign even if busy fix: give reason to reassign - allow team members to reassign even if busy Oct 25, 2024
Udit-takkar
Udit-takkar previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we also pass the reassign reason to email?

@sean-brydon sean-brydon marked this pull request as draft October 25, 2024 15:38
@CarinaWolli CarinaWolli marked this pull request as ready for review October 25, 2024 17:54
@dosubot dosubot bot added the emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email label Oct 25, 2024
@CarinaWolli CarinaWolli self-assigned this Oct 25, 2024
hbjORbj
hbjORbj previously approved these changes Oct 25, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

E2E results are ready!

zomars
zomars previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zomars zomars dismissed stale reviews from hbjORbj and themself via db059f5 October 25, 2024 18:53
zomars
zomars approved these changes Oct 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed conflicts in translations

@zomars zomars enabled auto-merge (squash) October 25, 2024 18:54
@zomars zomars merged commit c5402d8 into main Oct 25, 2024
@zomars zomars deleted the fix/rr-reassign-availability-members branch October 25, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbjORbj hbjORbj hbjORbj left review comments

@Udit-takkar Udit-takkar Udit-takkar left review comments

+1 more reviewer

@zomars zomars zomars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CarinaWolli CarinaWolli

Labels

consumer core area: core, team members only emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email ❗️ migrations contains migration files ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sean-brydon @zomars @hbjORbj @Udit-takkar @keithwillcode @CarinaWolli