Skip to content

fix: use UTC date in tasker#17329

Merged
zomars merged 1 commit into
mainfrom
fix/tasker-utc
Oct 25, 2024
Merged

fix: use UTC date in tasker#17329
zomars merged 1 commit into
mainfrom
fix/tasker-utc

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Oct 25, 2024

What does this PR do?

https://app.campsite.com/cal/posts/htorqjsf6uee

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 25, 2024
@dosubot dosubot Bot added the 🐛 bug Something isn't working label Oct 25, 2024
// Get only tasks that are scheduled to run now or in the past
scheduledAt: {
lt: new Date(),
lt: new Date().toUTCString(),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we store utc iso string in scheduledAt field in Task Table

@graphite-app graphite-app Bot requested a review from a team October 25, 2024 15:23
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@zomars zomars merged commit 96571df into main Oct 25, 2024
@zomars zomars deleted the fix/tasker-utc branch October 25, 2024 16:11
zomars added a commit that referenced this pull request Oct 25, 2024
zomars added a commit that referenced this pull request Oct 25, 2024
sean-brydon pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants