Skip to content

fix: Inconsistent phrasing and remove duplicate words in localization#17339

Merged
anikdhabal merged 2 commits into
mainfrom
AliPythonDev-patch-2
Oct 28, 2024
Merged

fix: Inconsistent phrasing and remove duplicate words in localization#17339
anikdhabal merged 2 commits into
mainfrom
AliPythonDev-patch-2

Conversation

@AlleyNawaz
Copy link
Copy Markdown
Contributor

@AlleyNawaz AlleyNawaz commented Oct 25, 2024

…strings in common.json

What does this PR do?

This PR refactors the localization strings in common.json for consistency and clarity, addressing several issues related to phrasing and grammatical accuracy. The changes enhance the overall readability of the user interface.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 25, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Inconsistent phrasing and remove duplicate words in localization #17339". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Oct 25, 2024
@dosubot dosubot Bot added the i18n area: i18n, translations label Oct 25, 2024
@graphite-app graphite-app Bot requested a review from a team October 25, 2024 19:13
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 25, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/26/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, please change the PR title to fix: Inconsistent phrasing and remove duplicate words in localization #17339

Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the PR title to fix: Inconsistent phrasing and remove duplicate words in localization #17339

@AlleyNawaz AlleyNawaz changed the title Fix inconsistent phrasing and remove duplicate words in localization … Inconsistent phrasing and remove duplicate words in localization #17339 Oct 26, 2024
@AlleyNawaz AlleyNawaz changed the title Inconsistent phrasing and remove duplicate words in localization #17339 fix: Inconsistent phrasing and remove duplicate words in localization #17339 Oct 26, 2024
@AlleyNawaz AlleyNawaz changed the title fix: Inconsistent phrasing and remove duplicate words in localization #17339 fix: Inconsistent phrasing and remove duplicate words in localization Oct 26, 2024
Praashh
Praashh previously approved these changes Oct 27, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 28, 2024 2:10pm
calcom-web-canary ⬜️ Ignored (Inspect) Oct 28, 2024 2:10pm

@anikdhabal anikdhabal enabled auto-merge (squash) October 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-interns The team responsible for reviewing, testing and shipping low/medium community PRs i18n area: i18n, translations ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants