fix: Tasker new Date is fixed to lambda lifetime

[zomars]

What does this PR do?

This pull request to packages/features/tasker/repository.ts includes changes to ensure that the whereUpcomingTasks condition always uses the current date. The most important changes involve refactoring the whereUpcomingTasks constant into a function to dynamically generate the query condition.

Refactoring whereUpcomingTasks:

• packages/features/tasker/repository.ts: Changed the whereUpcomingTasks constant to the makeWhereUpcomingTasks function to ensure that a new Date is always fresh. [1] [2]
• packages/features/tasker/repository.ts: Updated Task.getNextBatch to use the makeWhereUpcomingTasks function instead of the whereUpcomingTasks constant.
• packages/features/tasker/repository.ts: Updated Task.countUpcoming to use the makeWhereUpcomingTasks function instead of the whereUpcomingTasks constant.

• Fixes #XXXX (GitHub issue number)
• Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

• Are there environment variables that should be set?
• What are the minimal test data to have?
• What is expected (happy path) to have (input and output)?
• Any other important info that could help to test that PR

Checklist

• I haven't read the contributing guide
• My code doesn't follow the style guidelines of this project
• I haven't commented my code, particularly in hard-to-understand areas
• I haven't checked if my changes generate no new warnings

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "hotfix" found in pull request title "hotfix: Tasker new Date is fixed to lambda lifetime". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[graphite-app]

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (10/25/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/25/24)

1 label was added to this PR based on Keith Williams's automation.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2024 8:33pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2024 8:33pm

[github-actions]

E2E results are ready!

• Workflow #36188.1 latest results