feat: Salesforce RR Skip Accounts - Match On Email Domain#17350
Merged
Conversation
dosubot
Bot
added
crm-apps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/26/24)1 reviewer was added to this PR based on Keith Williams's automation. |
| `SELECT Id, Email, AccountId FROM Contact WHERE Email LIKE '%@${emailDomain}' AND AccountId != null` | ||
| ); | ||
|
|
||
| const accountId = this.getDominantAccountId(response.records as { AccountId: string }[]); |
Contributor
There was a problem hiding this comment.
Nit: Don't need to set this to accountId. Can just return.
Suggested change
| const accountId = this.getDominantAccountId(response.records as { AccountId: string }[]); | |
| return this.getDominantAccountId(response.records as { AccountId: string }[]); |
| ); | ||
|
|
||
| const accountId = this.getDominantAccountId(response.records as { AccountId: string }[]); | ||
| return accountId; |
Contributor
There was a problem hiding this comment.
Suggested change
| return accountId; |
Contributor
E2E results are ready! |
CarinaWolli
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently when RR skip on Salesforce is enabled and we check against the accounts, we check for the presence of the exact email of the attendee. Since accounts are made up of a collection of contacts, we should also match against the email domain of those contacts.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?