fix: Resolve lint errors by updating RerouteDialog.test.tsx#17352
Merged
Conversation
|
@mavishay is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
dosubot
Bot
added
the
🧹 Improvements
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/27/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (10/27/24)1 label was added to this PR based on Keith Williams's automation. |
Praashh
previously requested changes
Oct 27, 2024
Contributor
Praashh
left a comment
Praashh
left a comment
There was a problem hiding this comment.
can you remove this, don't think we need async function here.
| expect(eventTypeEl).toHaveTextContent(eventTypeText); | ||
| expect(eventTypeEl.querySelector("a")).toHaveAttribute("href", eventTypeHref); | ||
| await expect(eventTypeEl.querySelector("a")).toHaveAttribute("href", eventTypeHref); | ||
| } |
Contributor
There was a problem hiding this comment.
don't think, await are necessary. Can you share some references to look at the fix?
Contributor
There was a problem hiding this comment.
Hey @Praashh I think it's okay, as it's just fixing the lint error
Contributor
E2E results are ready! |
anikdhabal
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Another step of fixing build by fixing pre-running lint errors
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarnyarn --cwd apps/web workspace @calcom/web run buildand see the error disappear