fix: round robin re assignment google meet bug#17378
Conversation
github-actions
Bot
added
calendar-apps
dosubot
Bot
added
the
teams
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
Self review done
| const responses = responseSafeParse.success ? responseSafeParse.data : undefined; | ||
|
|
||
| let bookingLocation = booking.location; | ||
| if (eventType.locations.includes({ type: OrganizerDefaultConferencingAppType })) { |
There was a problem hiding this comment.
includes compare object by reference and not by value so this won't ever be true even when it contains an object { type: OrganizerDefaultConferencingAppType }
| if (results.length) { | ||
| // Handle Google Meet results | ||
| // We use the original booking location since the evt location changes to daily | ||
| if (bookingLocation === MeetLocationType) { | ||
| const googleMeetResult = { | ||
| appName: GoogleMeetMetadata.name, | ||
| type: "conferencing", | ||
| uid: results[0].uid, | ||
| originalEvent: results[0].originalEvent, | ||
| }; |
There was a problem hiding this comment.
Using the same code from handleNewBooking
There was a problem hiding this comment.
Can we reuse this code instead of copy/pasting?
There was a problem hiding this comment.
This is important logic that ideally lives in 1 place
There was a problem hiding this comment.
handleNewBooking is also doing a lot of things during rescheduling. It's mutating a lot of variables which could be difficult to track.
| prisma.booking.update({ | ||
| where: { id: bookingId }, | ||
| data: { metadata }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
update the new metadata to make sure new google meet url is saved
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/28/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
I'm reading through the code here and in handleNewBooking and the problem is that we're applying additional logic to the return array of referencesToCreate from the EventManager. Could we instead move this logic inside of the EventManager that way we don't have multiple instances of this logic?
|
@CarinaWolli everything should be fixed now. i was passing wrong metadata while updating booking |
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
@Udit-takkar @CarinaWolli I tested this again and it's working as expected. @CarinaWolli has pointed out this doesn't work if the two users have different conferencing apps but for now this fixes the issue when two users have Google Meet set as their default conferencing app.
4 participants
What does this PR do?
BEFORE:- Adds cal video
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Check all email's body