Skip to content

chore: ensure idempotency cancel booking api v2#17385

Merged
ThyMinimalDev merged 1 commit into
mainfrom
idempotency-v2-cancel-booking
Oct 29, 2024
Merged

chore: ensure idempotency cancel booking api v2#17385
ThyMinimalDev merged 1 commit into
mainfrom
idempotency-v2-cancel-booking

Conversation

@ThyMinimalDev
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev commented Oct 29, 2024

What does this PR do?

Ensure idempotency when cancelling bookings on api v2

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

yarn test:e2e bookings.controller.e2e-spec.ts

@dosubot dosubot Bot added api area: API, enterprise API, access token, OAuth bookings area: bookings, availability, timezones, double booking labels Oct 29, 2024
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Oct 29, 2024
@graphite-app graphite-app Bot requested a review from a team October 29, 2024 08:46
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 29, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@ThyMinimalDev ThyMinimalDev merged commit 85246f0 into main Oct 29, 2024
@ThyMinimalDev ThyMinimalDev deleted the idempotency-v2-cancel-booking branch October 29, 2024 10:20
ThyMinimalDev added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth bookings area: bookings, availability, timezones, double booking core area: core, team members only platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants