Skip to content

fix: virtualised member list for reassign#17386

Merged
CarinaWolli merged 12 commits into
mainfrom
feat/virtualised-reasign-members-select
Oct 29, 2024
Merged

fix: virtualised member list for reassign#17386
CarinaWolli merged 12 commits into
mainfrom
feat/virtualised-reasign-members-select

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

@sean-brydon sean-brydon commented Oct 29, 2024

Needs design sign off also.

What does this PR do?

CleanShot 2024-10-29 at 11 29 51

Fixes: CAL-4638

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added consumer core area: core, team members only labels Oct 29, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:52pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:52pm

@linear
Copy link
Copy Markdown

linear Bot commented Oct 29, 2024

@sean-brydon sean-brydon marked this pull request as ready for review October 29, 2024 14:55
@dosubot dosubot Bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Oct 29, 2024
@graphite-app graphite-app Bot requested a review from a team October 29, 2024 14:56
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to packages/lib

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 29, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/29/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, I think design looks good as well 👍

@CarinaWolli CarinaWolli enabled auto-merge (squash) October 29, 2024 17:18
@CarinaWolli CarinaWolli merged commit 55671db into main Oct 29, 2024
@CarinaWolli CarinaWolli deleted the feat/virtualised-reasign-members-select branch October 29, 2024 17:47
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants