Skip to content

fix: Users details leak for team booking when the team is private#17403

Merged
anikdhabal merged 8 commits intocalcom:mainfrom
anikdhabal:host_details_leak
Nov 11, 2024
Merged

fix: Users details leak for team booking when the team is private#17403
anikdhabal merged 8 commits intocalcom:mainfrom
anikdhabal:host_details_leak

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Oct 30, 2024

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
    Bug:-
    Currently the team is Private, but
image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 30, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@keithwillcode keithwillcode added the core area: core, team members only label Oct 30, 2024
@dosubot dosubot Bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Oct 30, 2024
@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Oct 30, 2024
@graphite-app graphite-app Bot requested a review from a team October 30, 2024 09:45
@anikdhabal anikdhabal added High priority Created by Linear-GitHub Sync and removed community Created by Linear-GitHub Sync labels Oct 30, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Oct 30, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/30/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (10/30/24)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title fix: Host details leak for team booking when the team is private fix: Users details leak for team booking when the team is private Oct 30, 2024
Comment thread packages/features/eventtypes/lib/getPublicEvent.ts Outdated
Comment thread packages/features/bookings/Booker/utils/event.ts Outdated
@keithwillcode keithwillcode added this to the v4.7 milestone Nov 3, 2024
Comment thread packages/features/eventtypes/lib/getPublicEvent.ts Outdated
Udit-takkar
Udit-takkar previously approved these changes Nov 11, 2024
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anikdhabal anikdhabal enabled auto-merge (squash) November 11, 2024 08:36
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@anikdhabal anikdhabal merged commit ae90638 into calcom:main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync ready-for-e2e teams area: teams, round robin, collective, managed event-types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants