chore: Replace prisma actions Credential Repository / SelectedCalendar Repository methods#17443
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/02/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
|
@hbjORbj sone unit tests are failing |
joeauyeung
left a comment
There was a problem hiding this comment.
This is on the right track @hbjORbj.
I noticed there are "Google" specific methods in the repositories. I think these repositories should be agnostic of any app they're interacting with, or else we would end up with a ton of methods for each specific app.
If you want to create any reusable functions for GCal I think it should live in the gcal folder. There we can call on the repository methods.
434bc82 to
fe8519d
Compare
|
@joeauyeung Thanks for the review. Good point, I made |
joeauyeung
left a comment
There was a problem hiding this comment.
I'll approve for now as the functionality works.
I'm a uneasy with the idea of having google specific functions living mixing with files that handle core logic. I think once we start working on #17251 there might be a better place to keep these files.
|
Thanks Joe. Joe and I agreed that we rename |
What does this PR do?
api/integrations/googlecalendar/callbackgoogle.tsfile inpackages/liband move google related methods thereMandatory Tasks (DO NOT REMOVE)