Skip to content

fix: disable all emails modal crash on platform#17485

Merged
ThyMinimalDev merged 1 commit into
mainfrom
fix/disable-emails-modal-text-update
Nov 6, 2024
Merged

fix: disable all emails modal crash on platform#17485
ThyMinimalDev merged 1 commit into
mainfrom
fix/disable-emails-modal-text-update

Conversation

@ibex088
Copy link
Copy Markdown
Contributor

@ibex088 ibex088 commented Nov 5, 2024

What does this PR do?

Screen.Recording.2024-11-05.at.1.09.12.PM.mov
  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Nov 5, 2024 11:56am
calcom-web-canary ⬜️ Ignored (Inspect) Nov 5, 2024 11:56am

@dosubot dosubot Bot added platform Anything related to our platform plan 🐛 bug Something isn't working labels Nov 5, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Nov 5, 2024
@graphite-app graphite-app Bot requested review from a team November 5, 2024 11:57
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed -- duplicate

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 5, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (11/05/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/05/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 5, 2024

E2E results are ready!

Comment on lines +40 to +46
This will disable all emails to {recipient}. This includes booking confirmations, requests,
reschedules and reschedule requests, cancellation emails, and any other emails related to
booking updates.
<br />
<br />
It is your responsibility to ensure that your {{ recipient }} are aware of any bookings and
changes to their bookings.
It is your responsibility to ensure that your {recipient} are aware of any bookings and changes
to their bookings.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 😄

@ThyMinimalDev ThyMinimalDev merged commit 21aaff0 into main Nov 6, 2024
@ThyMinimalDev ThyMinimalDev deleted the fix/disable-emails-modal-text-update branch November 6, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants