feat: adds attendee and host names, and guest emails in forwarded params#17530
Merged
alishaz-polymath merged 5 commits intomainfrom Nov 8, 2024
Merged
Conversation
dosubot
bot
added
bookings
keithwillcode
added
core
Udit-takkar
reviewed
Nov 7, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
…m:calcom/cal.com into fix/extensive-details-in-success-redirect
alishaz-polymath
commented
Nov 8, 2024
Comment on lines
+60
to
+64
| if (attendee.name) { | ||
| acc.hostNames.push(attendee.name); | ||
| } else if (attendee.email) { | ||
| acc.guestEmails.push(attendee.email); | ||
| } |
Member
Author
There was a problem hiding this comment.
guests don't have names, only emails.
alishaz-polymath
changed the title
zomars
approved these changes
Nov 8, 2024
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Not a blocker but is it kinda hard to figure out what going on with all the Object methods, reduce, etc. Maybe properly named functions could help?
Graphite Automations"Add ready-for-e2e label" took an action on this PR • (11/08/24)1 label was added to this PR based on Keith Williams's automation. |
hariombalhara
approved these changes
Nov 8, 2024
Contributor
E2E results are ready! |
Member
Author
Yeah, plan on making separate reusable functions in a follow up which should take care of that. |
alishaz-polymath
deleted the
fix/extensive-details-in-success-redirect
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The forward params in Redirect on booking was missing host name and booker name. We add those in this PR.
Example URL with params:
https://example.com/test/hello?date=2024-11-14&slot=2024-11-14T10%3A15%3A00.000Z&slug=redirect-team&type=chat-up&isSuccessBookingPage=true&email=danish%40example.com&eventTypeSlug=chat-up&title=Chat+up+between+Redirect+Team+and+Danish+Sultan&description=&startTime=2024-11-14T10%3A15%3A00.000Z&endTime=2024-11-14T10%3A30%3A00.000Z&location=integrations%3Adaily&hostName=Ali+Shahbaz%2C+John+Doe&attendeeName=Danish+Sultan&guestEmail=guest1%40gmail.com%2C+guest2%40gmail.com%2C+guest3%40gmail.com%2C+guest4%40gmail.com
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist