Skip to content

fix: Form link in Reroute Dialog gives 404 for members that aren't admin/owner of team#17537

Merged
anikdhabal merged 4 commits intocalcom:mainfrom
anikdhabal:access_denied
Nov 11, 2024
Merged

fix: Form link in Reroute Dialog gives 404 for members that aren't admin/owner of team#17537
anikdhabal merged 4 commits intocalcom:mainfrom
anikdhabal:access_denied

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

@anikdhabal anikdhabal commented Nov 7, 2024

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-4587

Instead of a general 404, redirect to a custom 403 page with a message

Screenshot 2024-11-07 171632

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A-I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A-I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 7, 2024

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@keithwillcode keithwillcode added the core area: core, team members only label Nov 7, 2024
@dosubot dosubot Bot added routing-forms area: routing forms, routing, forms 🐛 bug Something isn't working labels Nov 7, 2024
@graphite-app graphite-app Bot requested a review from a team November 7, 2024 12:11
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal added 🧹 Improvements Improvements to existing features. Mostly UX/UI and removed 🐛 bug Something isn't working labels Nov 7, 2024
@Udit-takkar Udit-takkar added this to the v4.7 milestone Nov 11, 2024
Comment thread apps/web/pages/403.tsx Outdated
Comment thread apps/web/pages/403.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@anikdhabal anikdhabal enabled auto-merge (squash) November 11, 2024 14:52
@anikdhabal anikdhabal merged commit 4d38c6d into calcom:main Nov 11, 2024
@anikdhabal anikdhabal deleted the access_denied branch November 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants