Skip to content

fix: Routing Form - Small Improvements#17538

Merged
hariombalhara merged 8 commits intomainfrom
small-improvements-routing-forms
Nov 11, 2024
Merged

fix: Routing Form - Small Improvements#17538
hariombalhara merged 8 commits intomainfrom
small-improvements-routing-forms

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Nov 7, 2024 •
edited
Loading

What does this PR do?

NOTE: Needs design approval before merging.

  • Fix title. On switching the tab the title was reset to 'Cal.com|cal.com' causing confusion as to which tab had the Routing Form.
  • Make route name editable. Give a meaningful name to your route that makes it easier to explain to others as well for the purpose of route.
  • Make route collapsible - Helps in easy rearranging of Routes and focussing on a single route only
    Loom

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • [N/A] I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot Bot added routing-forms area: routing forms, routing, forms 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Nov 7, 2024
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Nov 7, 2024
@graphite-app graphite-app Bot requested a review from a team November 7, 2024 12:20
@hariombalhara hariombalhara force-pushed the small-improvements-routing-forms branch from cab0bb4 to 7226dd5 Compare November 7, 2024 12:20
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 4:47am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 4:47am

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 7, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/07/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@Udit-takkar Udit-takkar added this to the v4.7 milestone Nov 7, 2024
Udit-takkar
Udit-takkar previously requested changes Nov 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing because of missing "use client"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 8, 2024 •
edited
Loading

E2E results are ready!

Udit-takkar
Udit-takkar previously approved these changes Nov 8, 2024
View reviewed changes
@hariombalhara
Copy link
Copy Markdown
Member Author

hariombalhara commented Nov 11, 2024

@Udit-takkar Icons test was failing. Updated the snapshot. Need a re-approval after tests pass.

@hariombalhara hariombalhara enabled auto-merge (squash) November 11, 2024 08:09
@hariombalhara hariombalhara merged commit 62aaba3 into main Nov 11, 2024
@hariombalhara hariombalhara deleted the small-improvements-routing-forms branch November 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

Assignees

No one assigned

Labels

core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

3 participants

@hariombalhara @Udit-takkar @keithwillcode