fix: move team availability search to serverside#17549
Merged
Udit-takkar merged 2 commits intomainfrom Nov 8, 2024
Merged
Conversation
dosubot
bot
added
teams
sean-brydon
commented
Nov 8, 2024
|
|
||
| const members = await Promise.all(buildMembers); | ||
|
|
||
| let belongsToTeam = true; |
Member
Author
There was a problem hiding this comment.
We do this logic to not show the upgrade tip if the filters return no users
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/08/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/08/24)1 label was added to this PR based on Keith Williams's automation. |
Udit-takkar
reviewed
Nov 8, 2024
Contributor
Udit-takkar
left a comment
Udit-takkar
left a comment
There was a problem hiding this comment.
Another issue in listTeamAvailability.handler(Not due to this PR) is we are executing UserRepository.enrichUserWithItsProfile sequentially. we can use Promise.all here
const membershipWithUserProfile = [];
for (const membership of memberships) {
membershipWithUserProfile.push({
...membership,
user: await UserRepository.enrichUserWithItsProfile({
user: membership.user,
}),
});
}
return membershipWithUserProfile;
This can be fixed in a follow up PR
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
approved these changes
Nov 8, 2024
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR faces an issue when people were searching team availability by user but the search was handled client side.
How should this be tested?
Load an organisation
Goto availability/teams page
Search for a user that is not visible in the list
Checklist