Skip to content

fix: pass upId to JWT if logging in through SAML#17566

Merged
keithwillcode merged 3 commits intomainfrom
write-upId-to-jwt-if-saml
Nov 8, 2024
Merged

fix: pass upId to JWT if logging in through SAML#17566
keithwillcode merged 3 commits intomainfrom
write-upId-to-jwt-if-saml

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app bot requested a review from a team November 8, 2024 22:15
@dosubot dosubot bot added the authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in label Nov 8, 2024
@joeauyeung joeauyeung changed the title pass upId to JWT if logging in through SAML fix: pass upId to JWT if logging in through SAML Nov 8, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 8, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "pass `upId` to JWT if logging in through SAML". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 10:23pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 10:23pm

@keithwillcode keithwillcode added consumer core area: core, team members only labels Nov 8, 2024
keithwillcode
keithwillcode previously approved these changes Nov 8, 2024
@keithwillcode keithwillcode enabled auto-merge (squash) November 8, 2024 22:17
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Nov 8, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/08/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/08/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 8, 2024

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants