Skip to content

fix: iframe issue for atoms documentation#17570

Merged
Ryukemeister merged 3 commits intomainfrom
fix-iframe-issues-for-atoms
Nov 11, 2024
Merged

fix: iframe issue for atoms documentation#17570
Ryukemeister merged 3 commits intomainfrom
fix-iframe-issues-for-atoms

Conversation

@Ryukemeister
Copy link
Copy Markdown
Contributor

@Ryukemeister Ryukemeister commented Nov 9, 2024

What does this PR do?

  • The iframe for loom videos always used to overflow the div, causing the container and screen to break for mobile devices. The reason was that we had a property for the iframe width="560", this was causing the width to be 560px always irrespective of the screen size.
  • To fix this, I changed the css styles to add a max-width instead of a fixed width

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can be tested in the docs folder; cd into docs and run mintlify dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 7:24am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 7:24am

@Ryukemeister Ryukemeister marked this pull request as ready for review November 11, 2024 07:24
@graphite-app graphite-app Bot requested a review from a team November 11, 2024 07:24
@dosubot dosubot Bot added the docs area: docs, documentation, cal.com/docs label Nov 11, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 11, 2024

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (11/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/11/24)

1 label was added to this PR based on Keith Williams's automation.

@Ryukemeister Ryukemeister enabled auto-merge (squash) November 11, 2024 08:15
@Ryukemeister Ryukemeister merged commit 838e8b9 into main Nov 11, 2024
@Ryukemeister Ryukemeister deleted the fix-iframe-issues-for-atoms branch November 11, 2024 08:28
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only docs area: docs, documentation, cal.com/docs platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants