Merged
Conversation
dosubot
bot
added
platform
ThyMinimalDev
commented
Nov 11, 2024
Comment on lines
+112
to
+113
| case "checkout.session.completed": | ||
| await this.billingService.handleStripeCheckoutEvents(event); |
Contributor
Author
There was a problem hiding this comment.
subscribe / upgrade
ThyMinimalDev
commented
Nov 11, 2024
Comment on lines
+115
to
+116
| case "customer.subscription.deleted": | ||
| await this.billingService.handleStripeSubscriptionDeleted(event); |
Contributor
Author
There was a problem hiding this comment.
stripe deleted subscription after multiple failed payment retries
ThyMinimalDev
commented
Nov 11, 2024
Comment on lines
+118
to
+119
| case "invoice.payment_failed": | ||
| await this.billingService.handleStripePaymentFailed(event); |
Contributor
Author
There was a problem hiding this comment.
payment failed, mark subscription as overdue
ThyMinimalDev
commented
Nov 11, 2024
Comment on lines
+121
to
+122
| case "invoice.payment_succeeded": | ||
| await this.billingService.handleStripePaymentSuccess(event); |
Contributor
Author
There was a problem hiding this comment.
payment success, mark subscription as not overdue
Graphite Automations"Add platform team as reviewer" took an action on this PR • (11/11/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
supalarry
approved these changes
Nov 12, 2024
| @@ -1,8 +1,9 @@ | |||
| export enum PlatformPlan { | |||
| FREE = "FREE", | |||
| STARTER = "STARTER", | |||
Contributor
There was a problem hiding this comment.
if starter does not exist anymore, shouldn't we remove it from codebase?
Contributor
Author
There was a problem hiding this comment.
not while we have people still using this plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace Platform Starter Plan with a new Free plan
also mark payment as overdue when payment fails and cancel subscription when deleted by stripe
Mandatory Tasks (DO NOT REMOVE)