Skip to content

fix: resolved troubleshoot-sidbar bug#17613

Merged
keithwillcode merged 5 commits intocalcom:mainfrom
sachinsiddhu112:fix/17610-Troubleshoot-sidebar
Nov 14, 2024
Merged

fix: resolved troubleshoot-sidbar bug#17613
keithwillcode merged 5 commits intocalcom:mainfrom
sachinsiddhu112:fix/17610-Troubleshoot-sidebar

Conversation

@sachinsiddhu112
Copy link
Copy Markdown
Contributor

@sachinsiddhu112 sachinsiddhu112 commented Nov 13, 2024

What does this PR do?

This PR is resolving the UI bug in Troubleshoot page. On Troubleshoot page, If we scroll ,the sidebar shows some weird behaviour. If we scroll very slow ,we can clearly see that ,when we scroll the sidebar move upward.

I replaced the StickyBox wrapper for TroublshooterSidebar component in Troubleshooter.tsx component with simple div tag with some tailwind class properties.

Mandatory Tasks (DO NOT REMOVE)

  • Yes, I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • NA,I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

To test it, You can go to Troubleshoot page in Availability section and scroll up and down very slow or even fast, but the sidebar will remain stick.

Checklist

TroubleshootIssueResolved.mp4
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 13, 2024

@sachinsiddhu is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Nov 13, 2024
@graphite-app graphite-app Bot requested a review from a team November 13, 2024 08:35
@github-actions github-actions Bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Nov 13, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "resolved troubleshoot-sidbar bug". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 13, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sachinsiddhu112
❌ sachinsiddhu
You have signed the CLA already but the status is still pending? Let us recheck it.

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 13, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/13/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh
Copy link
Copy Markdown
Contributor

Praashh commented Nov 13, 2024

hey @sachinsiddhu112 , can you please sign CLA?

@anikdhabal anikdhabal changed the title resolved troubleshoot-sidbar bug fix: resolved troubleshoot-sidbar bug Nov 13, 2024
Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify it by getting rid of the children div and removing the StickyBox import if we're not using it

         <div className="sticky top-0 z-10 ps-6">
              <TroubleshooterSidebar />
          </div>

@Praashh Praashh self-assigned this Nov 13, 2024
@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

Do I need to make the changes you mentioned?

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

I have signed the CLA.

@Praashh
Copy link
Copy Markdown
Contributor

Praashh commented Nov 13, 2024

Do I need to make the changes you mentioned?

yes, that would make it consistent and also readable

@Praashh
Copy link
Copy Markdown
Contributor

Praashh commented Nov 13, 2024

I have signed the CLA.

you probably put the wrong username while signing the CLA, use sachinsiddhu112 username

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

How can I resign the CLA?

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

I have signed CLA again, but when I signed, It is taking username by default from Github.

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

And I have made the requested changes and committed them.

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

It's my very first contribution. So don't know much about it.
Is my changes merged or do I have to do something to do that.

@Praashh
Copy link
Copy Markdown
Contributor

Praashh commented Nov 13, 2024

It's my very first contribution. So don't know much about it. Is my changes merged or do I have to do something to do that.

don't worry, go though it https://cla-assistant.io/calcom/cal.com?pullRequest=17613

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

I have signed CTA. Now my username should be correct. It is showing me verified.
What about my PR, it has not merged because some checks had failed.
What I have to do?

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

Can I start working on next issue?

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

I have made those changes. Pleaase merge the PR, If it is correct.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 13, 2024

E2E results are ready!

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

Is there something wrong in this PR Or the merging process going on? I am asking because , it is not getting merged.

@Ryukemeister
Copy link
Copy Markdown
Contributor

Is there something wrong in this PR Or the merging process going on? I am asking because , it is not getting merged.

Hey Sachin, thanks a lot for you contribution! The PR is currently under review which means @Praashh will go through your code and make sure the code quality and logic are correct, once that is correct he'll approve it and then we'll make sure all checks are passing. Once its approved and all checks are passing, we'll make sure to merge it.

Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachinsiddhu112 please sign CLA, changes LGTM.

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

I already signed the CLA. Is it updated.

@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

changes LGTM ?

@Praashh
Copy link
Copy Markdown
Contributor

Praashh commented Nov 14, 2024

changes LGTM ?

looks good to me. don't worry I approved your PR, we'll merge it soon.

@keithwillcode keithwillcode merged commit 1ff6465 into calcom:main Nov 14, 2024
@sachinsiddhu112
Copy link
Copy Markdown
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Troubleshoot Jerky Sidebar

6 participants