fix: resolved troubleshoot-sidbar bug#17613
Conversation
|
@sachinsiddhu is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/13/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/13/24)1 label was added to this PR based on Keith Williams's automation. |
|
hey @sachinsiddhu112 , can you please sign CLA? |
|
Do I need to make the changes you mentioned? |
|
I have signed the CLA. |
yes, that would make it consistent and also readable |
you probably put the wrong username while signing the CLA, use sachinsiddhu112 username |
|
How can I resign the CLA? |
|
I have signed CLA again, but when I signed, It is taking username by default from Github. |
|
And I have made the requested changes and committed them. |
|
It's my very first contribution. So don't know much about it. |
don't worry, go though it https://cla-assistant.io/calcom/cal.com?pullRequest=17613 |
|
I have signed CTA. Now my username should be correct. It is showing me verified. |
|
Can I start working on next issue? |
|
I have made those changes. Pleaase merge the PR, If it is correct. |
E2E results are ready! |
|
Is there something wrong in this PR Or the merging process going on? I am asking because , it is not getting merged. |
Hey Sachin, thanks a lot for you contribution! The PR is currently under review which means @Praashh will go through your code and make sure the code quality and logic are correct, once that is correct he'll approve it and then we'll make sure all checks are passing. Once its approved and all checks are passing, we'll make sure to merge it. |
There was a problem hiding this comment.
@sachinsiddhu112 please sign CLA, changes LGTM.
|
I already signed the CLA. Is it updated. |
|
changes LGTM ? |
looks good to me. don't worry I approved your PR, we'll merge it soon. |
|
Thanks. |
What does this PR do?
This PR is resolving the UI bug in Troubleshoot page. On Troubleshoot page, If we scroll ,the sidebar shows some weird behaviour. If we scroll very slow ,we can clearly see that ,when we scroll the sidebar move upward.
I replaced the StickyBox wrapper for TroublshooterSidebar component in Troubleshooter.tsx component with simple div tag with some tailwind class properties.
Mandatory Tasks (DO NOT REMOVE)
To test it, You can go to Troubleshoot page in Availability section and scroll up and down very slow or even fast, but the sidebar will remain stick.
Checklist
TroubleshootIssueResolved.mp4