Skip to content

feat: allow marking no show after booking has started#17625

Merged
Udit-takkar merged 3 commits intocalcom:mainfrom
kart1ka:feat/allow-marking-no-show-after-booking-started
Nov 14, 2024
Merged

feat: allow marking no show after booking has started#17625
Udit-takkar merged 3 commits intocalcom:mainfrom
kart1ka:feat/allow-marking-no-show-after-booking-started

Conversation

@kart1ka
Copy link
Copy Markdown
Collaborator

@kart1ka kart1ka commented Nov 13, 2024 •
edited
Loading

What does this PR do?

Loom - https://www.loom.com/share/1c39fb292a5b42f78898b51aa272dffa?sid=0c3e75e3-53f0-433b-a803-1835b88da48d

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 13, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Nov 13, 2024
@graphite-app graphite-app Bot requested a review from a team November 13, 2024 17:41
@github-actions github-actions Bot added bookings area: bookings, availability, timezones, double booking Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Nov 13, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 13, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/14/24)

1 label was added to this PR based on Keith Williams's automation.

@Praashh Praashh self-assigned this Nov 13, 2024
Udit-takkar
Udit-takkar approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. works fine

@Udit-takkar Udit-takkar enabled auto-merge (squash) November 14, 2024 09:35
Praashh
Praashh approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kart1ka , LGTM!!

@Udit-takkar Udit-takkar merged commit ff2754f into calcom:main Nov 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 14, 2024

E2E results are ready!

@VK-RED VK-RED mentioned this pull request Nov 14, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Udit-takkar Udit-takkar Udit-takkar approved these changes

+1 more reviewer

@Praashh Praashh Praashh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Praashh Praashh

Labels

bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CAL-4703] Allow marking no-show after booking started

3 participants

@kart1ka @Udit-takkar @Praashh