Skip to content

feat: Salesforce when create contacts under an account if creating leads is chosen [CAL-4713]#17630

Merged
joeauyeung merged 3 commits intomainfrom
salesforce-provide-option-to-create-contact-under-account
Nov 14, 2024
Merged

feat: Salesforce when create contacts under an account if creating leads is chosen [CAL-4713]#17630
joeauyeung merged 3 commits intomainfrom
salesforce-provide-option-to-create-contact-under-account

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR enables the option to create contacts under an account if choosing to create events on leads. The PR uses current functionality to search if the attendee or contacts that share the same email domain as the attendee belong to an account. Then create the contact under the account and the event.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@linear
Copy link
Copy Markdown

linear Bot commented Nov 14, 2024

@graphite-app graphite-app Bot requested a review from a team November 14, 2024 03:37
@dosubot dosubot Bot added consumer crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request labels Nov 14, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Nov 14, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeauyeung joeauyeung merged commit 3589767 into main Nov 14, 2024
@joeauyeung joeauyeung deleted the salesforce-provide-option-to-create-contact-under-account branch November 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants