Skip to content

revert: "feat: Populate gCal calendar cache via webhooks (#11928)""#17682

Merged
zomars merged 3 commits intomainfrom
revert-17675-revert/calendar-cache
Nov 18, 2024
Merged

revert: "feat: Populate gCal calendar cache via webhooks (#11928)""#17682
zomars merged 3 commits intomainfrom
revert-17675-revert/calendar-cache

Conversation

@zomars
Copy link
Copy Markdown
Contributor

@zomars zomars commented Nov 16, 2024 •
edited
Loading

Reverts #17675

Removed Next.js App Dir code to prevent OOM issues on Vercel.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Nov 18, 2024 6:07pm
calcom-web-canary ⬜️ Ignored (Inspect) Nov 18, 2024 6:07pm

@graphite-app graphite-app Bot requested a review from a team November 16, 2024 01:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 16, 2024 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Revert "revert: "feat: Populate gCal calendar cache via webhooks  (#11928)""". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions Bot added ❗️ migrations contains migration files ❗️ .env changes contains changes to env variables labels Nov 16, 2024
@dosubot dosubot Bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar webhooks area: webhooks, callback, webhook payload labels Nov 16, 2024
@keithwillcode keithwillcode added core area: core, team members only foundation labels Nov 16, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 16, 2024 •
edited
Loading

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (11/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/18/24)

1 label was added to this PR based on Keith Williams's automation.

@zomars zomars marked this pull request as draft November 16, 2024 03:22
zomars
zomars commented Nov 18, 2024
View reviewed changes
Comment thread apps/web/pages/api/calendar-cache/cron.ts
Copy link
Copy Markdown
Contributor Author

@zomars zomars Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrated to API route in pages instead of App Dir

@zomars zomars changed the title Revert "revert: "feat: Populate gCal calendar cache via webhooks (#11928)"" revert: "feat: Populate gCal calendar cache via webhooks (#11928)"" Nov 18, 2024
@zomars zomars marked this pull request as ready for review November 18, 2024 19:14
@zomars
Copy link
Copy Markdown
Contributor Author

zomars commented Nov 18, 2024

@keithwillcode removed app dir code to try deploying this again.

@zomars zomars enabled auto-merge (squash) November 18, 2024 19:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2024

E2E results are ready!

@zomars zomars merged commit 7c0ee9f into main Nov 18, 2024
@zomars zomars deleted the revert-17675-revert/calendar-cache branch November 18, 2024 19:48
@Udit-takkar Udit-takkar mentioned this pull request Dec 2, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithwillcode keithwillcode keithwillcode approved these changes

Assignees

No one assigned

Labels

app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only ❗️ .env changes contains changes to env variables foundation ❗️ migrations contains migration files ready-for-e2e webhooks area: webhooks, callback, webhook payload

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zomars @keithwillcode