Skip to content

chore: add default reading direction to atoms wrapper#17710

Merged
ThyMinimalDev merged 2 commits intomainfrom
platform-atoms-wrapper-reading-direction
Nov 18, 2024
Merged

chore: add default reading direction to atoms wrapper#17710
ThyMinimalDev merged 2 commits intomainfrom
platform-atoms-wrapper-reading-direction

Conversation

@ThyMinimalDev
Copy link
Copy Markdown
Contributor

@ThyMinimalDev ThyMinimalDev commented Nov 18, 2024 •
edited
Loading

What does this PR do?

Set default reading direction so that most platform users don't need to do it manually

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@dosubot dosubot Bot added the platform Anything related to our platform plan label Nov 18, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Nov 18, 2024
@graphite-app graphite-app Bot requested a review from a team November 18, 2024 08:15
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 18, 2024 •
edited
Loading

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (11/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/18/24)

1 label was added to this PR based on Keith Williams's automation.

supalarry
supalarry approved these changes Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) November 18, 2024 08:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2024 •
edited
Loading

E2E results are ready!

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 0:06am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 0:06am

@ThyMinimalDev ThyMinimalDev merged commit 12e78a7 into main Nov 18, 2024
@ThyMinimalDev ThyMinimalDev deleted the platform-atoms-wrapper-reading-direction branch November 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@supalarry supalarry supalarry approved these changes

Assignees

No one assigned

Labels

core area: core, team members only platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThyMinimalDev @supalarry @keithwillcode