fix: provide explicit column width for member list#17718
Merged
eunjae-lee merged 3 commits intomainfrom Nov 18, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
ui
eunjae-lee
commented
Nov 18, 2024
| id: "select", | ||
| enableHiding: false, | ||
| enableSorting: false, | ||
| size: 30, |
Contributor
Author
There was a problem hiding this comment.
explicit column sizes for these 3 columns, and the rest will be decided by tanstack table
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/18/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/18/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
E2E results are ready! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All the columns didn't have width assigned. So the column widths can be flickering while scrolling (when the column content size varies)
(before this PR)
https://github.com/user-attachments/assets/5aa28e50-9058-472c-a122-5f2b9cb5c6d8
Now, this PR applies column widths. I've brought the implementation from TanStack Table Column Resizing Performant, although I didn't implement the resizing itself.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist