fix: fix date comparison for OOO#17756
Merged
Merged
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/02/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
|
Could we add some tests to verify this functionality? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
emrysal
approved these changes
Dec 2, 2024
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Looks good to me now, lgtm
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a follow-up of #17736
We were comparing dates in a wrong way for OOO on the server side (See "❗Question" section at #17736)
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Creating and editing OOO should work correctly as-is.