-
Notifications
You must be signed in to change notification settings - Fork 13.1k
feat: added insights badge to event-types #17762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
PeerRich
wants to merge
10
commits into
main
from
17471-cal-4667-event-types-add-analytics-button-to-link-to-insights-1
+41
−1
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b582c35
added insights badge to event-types
PeerRich 53ef5c7
added comment
PeerRich 9bf27ec
added insights to event-types detail
PeerRich 1fb838c
added new i18n tag for total bookings
PeerRich af9fef0
Merge branch 'main' into 17471-cal-4667-event-types-add-analytics-but…
PeerRich 31353ed
Merge branch 'main' into 17471-cal-4667-event-types-add-analytics-but…
PeerRich d1204ca
feat: total booking query
Praashh 4506f42
Merge branch 'main' into 17471-cal-4667-event-types-add-analytics-but…
anikdhabal 0a09d33
Merge branch 'main' into 17471-cal-4667-event-types-add-analytics-but…
PeerRich a619ded
Merge branch 'main' into 17471-cal-4667-event-types-add-analytics-but…
PeerRich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import type { Prisma } from "@prisma/client"; | ||
| import Link from "next/link"; | ||
| import { useMemo } from "react"; | ||
| import type { z } from "zod"; | ||
|
|
||
|
|
@@ -25,13 +26,15 @@ export type EventTypeDescriptionProps = { | |
| className?: string; | ||
| shortenDescription?: boolean; | ||
| isPublic?: boolean; | ||
| totalBookings?: number; | ||
| }; | ||
|
|
||
| export const EventTypeDescription = ({ | ||
| eventType, | ||
| className, | ||
| shortenDescription, | ||
| isPublic, | ||
| totalBookings, | ||
| }: EventTypeDescriptionProps) => { | ||
| const { t, i18n } = useLocale(); | ||
|
|
||
|
|
@@ -76,6 +79,7 @@ export const EventTypeDescription = ({ | |
| </Badge> | ||
| </li> | ||
| )} | ||
|
|
||
| {eventType.schedulingType && eventType.schedulingType !== SchedulingType.MANAGED && ( | ||
| <li> | ||
| <Badge variant="gray" startIcon="users"> | ||
|
|
@@ -134,6 +138,13 @@ export const EventTypeDescription = ({ | |
| </Badge> | ||
| </li> | ||
| ) : null} | ||
| <li> | ||
| <Link href={`/insights?isAll=false&filter=event-type&eventTypeId=${eventType.id}`}> | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @eunjae-lee @sean-brydon this is currently not working consistently because the URL-param are borked. that PR needs to go live first |
||
| <Badge variant="gray" startIcon="chart-bar"> | ||
| <p>{t("event_type_insights", { numberOfBookings: totalBookings })} </p> | ||
| </Badge> | ||
| </Link> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| </> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeerRich the total booking badge would be useless for orgs and big teams. As they would have more than 50 bookings for most of the event types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus this would be really slow query for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Udit-takkar any ideas how to fix this?