fix: ai translations description for atoms#17875
Merged
Merged
Conversation
keithwillcode
added
core
Graphite Automations"Add platform team as reviewer" took an action on this PR • (11/27/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hbjORbj
previously requested changes
Nov 27, 2024
| event={event.data} | ||
| isPending={event.isPending} | ||
| isPlatform={isPlatform} | ||
| i18nLocales={i18nLocales} |
Contributor
There was a problem hiding this comment.
double checking: you don't need to pass userLocale here?
| eventMetaTitle?: string; | ||
| eventMetaTimezoneSelect?: string; | ||
| }; | ||
| locale?: string | null; |
Contributor
There was a problem hiding this comment.
shouldn't this be userLocale? based on the other changes you added
| isPlatform={false} | ||
| areInstantMeetingParametersSet={areInstantMeetingParametersSet} | ||
| userLocale={session?.user.locale} | ||
| i18nLocales={i18nLocales} |
Contributor
There was a problem hiding this comment.
Hmm passing a prop doesn't seem optimal. I'd suggest importing it from i18n.json where it's needed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
Bot
added
event-types
hbjORbj
reviewed
Nov 27, 2024
| (trans) => | ||
| trans.field === EventTypeAutoTranslatedField.DESCRIPTION && | ||
| i18nLocales.includes(trans.targetLocale) && | ||
| i18nLocales.locale.targets.includes(trans.targetLocale) && |
Contributor
There was a problem hiding this comment.
- i18nLocales name is misleading
i18n.locale.targets.concat([i18n.locale.source])
Contributor
E2E results are ready! |
ThyMinimalDev
approved these changes
Dec 2, 2024
emrysal
dismissed
hbjORbj’s stale review
Approved by @morgan - looks like issues addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
build platform atoms