fix: bulk attribute assignment#17896
Merged
eunjae-lee merged 5 commits intoNov 29, 2024
Merged
Conversation
eunjae-lee
commented
Nov 28, 2024
| ); | ||
| return ( | ||
| <> | ||
| <Fragment key={team.teamId}> |
Contributor
Author
There was a problem hiding this comment.
Not related to this PR, but saw a warning message during the test.
eunjae-lee
commented
Nov 28, 2024
| export function MassAssignAttributesBulkAction({ table, filters }: Props) { | ||
| const { selectedAttribute, setSelectedAttribute, foundAttributeInCache } = useSelectedAttributes(); | ||
| const [selectedAttributeOptions, setSelectedAttributeOptions] = useSelectedAttributeOption(); | ||
| function Content({ showMultiSelectWarning }: { showMultiSelectWarning: boolean }) { |
Contributor
Author
There was a problem hiding this comment.
I've extracted Content out of the main component. The implementation is almost the same.
remove comment
eunjae-lee
force-pushed
the
eunjae/cal-4817-bulk-attribute-assignment-behaving-weirdly-not-able-to
branch
from
a99d24e to
c043c77
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
…having-weirdly-not-able-to
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/29/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/29/24)1 label was added to this PR based on Keith Williams's automation. |
sean-brydon
previously approved these changes
Nov 29, 2024
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
LGTM - yeah makes sense i dont think we need this state in nuqs
Contributor
E2E results are ready! |
…dly-not-able-to' of github.com:calcom/cal.com into eunjae/cal-4817-bulk-attribute-assignment-behaving-weirdly-not-able-to
sean-brydon
approved these changes
Nov 29, 2024
eunjae-lee
deleted the
eunjae/cal-4817-bulk-attribute-assignment-behaving-weirdly-not-able-to
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bulk attribution assignment.
I haven't found the root cause yet, but it looks like nuqs didn't get the query parameter when it was actually there. Within this component, we don't need to keep the state in the query parameters because it's just temporary UI state that doesn't need to be saved in the URL. Also, this state isn't something that needs to be shared with others or refreshable. So, I moved it to a local React Context.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
↑ I recommend this setting for this PR.
FYI
I've found a bug on the server side, but it's not directly related to this UI issue. So I created a ticket: https://linear.app/calcom/issue/CAL-4819/bulk-attribution-appends-new-item-to-a-single-select-attribute-instead