fix: Added proper updates/interactivity on the "Getting started" app integ…#17903
Merged
Conversation
…rations. - InstallAppButtonWithoutPlanCheck properly vends the mutation data in the render's props - Fixed the improper props wiring in the AppConnectionItem - Added a loading state for reactivity
|
@itsalam is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/28/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/28/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (11/29/24)1 label was added to this PR based on Keith Williams's automation. |
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
InstallAppButtonWithoutPlanCheck properly vends the mutation data in the render's props
Fixed the improper props wiring in the AppConnectionItem
Added a loading state for reactivity
Added toaster for error/success confirmation
Loom Video: https://www.loom.com/share/c394fc8e94964636bd016c85c72b7782?sid=108960f6-f1e5-46c1-8ebc-00cce78690bf
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/claim #17900