Skip to content

fix: Added proper updates/interactivity on the "Getting started" app integ…#17903

Merged
PeerRich merged 3 commits into
calcom:mainfrom
itsalam:cal-4818-app-install-hang
Nov 29, 2024
Merged

fix: Added proper updates/interactivity on the "Getting started" app integ…#17903
PeerRich merged 3 commits into
calcom:mainfrom
itsalam:cal-4818-app-install-hang

Conversation

@itsalam
Copy link
Copy Markdown
Contributor

@itsalam itsalam commented Nov 28, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • N/A
  • What are the minimal test data to have?
  • A user configured to view the "getting started" page.
  • What is expected (happy path) to have (input and output)?
    • When the user clicks on a "connect" button, the loading animation should play, and the TRPC query should be invalidated on success.
  • Any other important info that could help to test that PR
    • N/A

/claim #17900

…rations.

- InstallAppButtonWithoutPlanCheck properly vends the mutation data in the render's props
- Fixed the improper props wiring in the AppConnectionItem
- Added a loading state for reactivity
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 28, 2024

@itsalam is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Nov 28, 2024
@graphite-app graphite-app Bot requested a review from a team November 28, 2024 22:25
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Nov 28, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (11/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (11/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (11/29/24)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 28, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Added proper updates/interactivity on the "Getting started" app integ…". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions Bot added performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive 🐛 bug Something isn't working 💎 Bounty A bounty on Algora.io labels Nov 28, 2024
@dosubot dosubot Bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Nov 28, 2024
@itsalam itsalam changed the title Added proper updates/interactivity on the "Getting started" app integ… fix: Added proper updates/interactivity on the "Getting started" app integ… Nov 28, 2024
@Praashh Praashh self-assigned this Nov 29, 2024
Copy link
Copy Markdown
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 29, 2024

E2E results are ready!

@PeerRich PeerRich merged commit 01b1f5b into calcom:main Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim 💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-4818] find out why "installing roam" took so long and fix it

3 participants