fix: Date Range Picker behavior#17914
Merged
Merged
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
Bot
added
ui
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/29/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/02/24)1 label was added to this PR based on Keith Williams's automation. |
anikdhabal
commented
Dec 1, 2024
Comment on lines
+28
to
+30
| function handleDayClick(date: Date) { | ||
| if (dates?.endDate) { | ||
| onDatesChange({ startDate: date, endDate: undefined }); |
Contributor
Author
There was a problem hiding this comment.
first click = start, second click = end
sean-brydon
previously approved these changes
Dec 2, 2024
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
LGTM - UX here is much better ty
Contributor
E2E results are ready! |
Praashh
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist