Skip to content

feat: routing form table merge columns #17938

Merged
Udit-takkar merged 3 commits intomainfrom
fix/duplicate-columns-via-label-not-id
Dec 2, 2024
Merged

feat: routing form table merge columns #17938
Udit-takkar merged 3 commits intomainfrom
fix/duplicate-columns-via-label-not-id

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

What does this PR do?

Replicate:

CleanShot 2024-12-02 at 08 29 02

Before:
CleanShot 2024-12-02 at 08 30 46

After:

CleanShot 2024-12-02 at 08 28 33

@graphite-app graphite-app bot requested a review from a team December 2, 2024 08:31
@dosubot dosubot bot added routing-forms area: routing forms, routing, forms ✨ feature New feature or request labels Dec 2, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 2, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Dec 2, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/02/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/02/24)

1 label was added to this PR based on Keith Williams's automation.

Udit-takkar
Udit-takkar previously approved these changes Dec 2, 2024
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Udit-takkar Udit-takkar enabled auto-merge (squash) December 2, 2024 09:42

// Group headers by label
const headersByLabel = headers.reduce((acc, header) => {
if (!acc[header.label]) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about case-sensitive changes? Skill vs skill

hariombalhara
hariombalhara previously approved these changes Dec 2, 2024
@sean-brydon sean-brydon dismissed stale reviews from hariombalhara and Udit-takkar via 709e4b3 December 2, 2024 10:08
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 6:46pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 6:46pm

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved by @hariombalhara

Happy to stamp also 🚀

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 2, 2024

E2E results are ready!

@Udit-takkar Udit-takkar merged commit a3ceefc into main Dec 2, 2024
@Udit-takkar Udit-takkar deleted the fix/duplicate-columns-via-label-not-id branch December 2, 2024 19:21
sean-brydon added a commit that referenced this pull request Dec 3, 2024
keithwillcode pushed a commit that referenced this pull request Dec 3, 2024
keithwillcode pushed a commit that referenced this pull request Dec 3, 2024
PeerRich pushed a commit that referenced this pull request Dec 3, 2024
* Revert "merge columns (#17938)"

This reverts commit a3ceefc.

* fix hovercard on responses
PeerRich pushed a commit that referenced this pull request Dec 9, 2024
* Revert "merge columns (#17938)"

This reverts commit a3ceefc.

* sort order by status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ✨ feature New feature or request ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants