Skip to content

feat: Salesforce - add option to ignore guests#17956

Merged
emrysal merged 2 commits intomainfrom
salesforce-do-not-create-records-for-guests
Dec 3, 2024
Merged

feat: Salesforce - add option to ignore guests#17956
emrysal merged 2 commits intomainfrom
salesforce-do-not-create-records-for-guests

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Adds an option to ignore added guests when creating new records / events in Salesforce

https://www.loom.com/share/c1b3d8d63c50415a85a86d2b9d3cf968

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Add Salesforce to an event
  • Enable the option to ignore guests
  • Create a booking with added guests
  • Only one record should be created

@graphite-app graphite-app bot requested a review from a team December 3, 2024 01:56
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 3, 2024
@dosubot dosubot bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request labels Dec 3, 2024
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Dec 3, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/03/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2024

E2E results are ready!

const sendNoShowAttendeeDataField = getAppData("sendNoShowAttendeeDataField") ?? "";
const onBookingWriteToRecord = getAppData("onBookingWriteToRecord") ?? false;
const onBookingWriteToRecordFields = getAppData("onBookingWriteToRecordFields") ?? {};
const ignoreGuests = getAppData("ignoreGuests") ?? false;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we think about making it by default true?

@emrysal emrysal merged commit bd83b36 into main Dec 3, 2024
@emrysal emrysal deleted the salesforce-do-not-create-records-for-guests branch December 3, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ✨ feature New feature or request ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants