Skip to content

chore: don't show the parent managed eventType as event redirection option#17993

Merged
anikdhabal merged 1 commit into
mainfrom
managed_evt
Dec 4, 2024
Merged

chore: don't show the parent managed eventType as event redirection option#17993
anikdhabal merged 1 commit into
mainfrom
managed_evt

Conversation

@anikdhabal
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot requested a review from a team December 4, 2024 07:56
@dosubot dosubot Bot added the routing-forms area: routing forms, routing, forms label Dec 4, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Dec 4, 2024
Comment on lines +170 to +172
if (eventType.teamId && eventType.schedulingType === SchedulingType.MANAGED) {
return;
}
Copy link
Copy Markdown
Contributor Author

@anikdhabal anikdhabal Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A parent-managed event type always shows no availability, it cannot be booked

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Dec 4, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/04/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/04/24)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. could you link the issue or campsite post about this?

@anikdhabal
Copy link
Copy Markdown
Contributor Author

Looks fine. could you link the issue or campsite post about this?

No campsite post we are receiving issue reports from customers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2024

E2E results are ready!

@anikdhabal anikdhabal merged commit 3dff77f into main Dec 4, 2024
@anikdhabal anikdhabal deleted the managed_evt branch December 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ready-for-e2e routing-forms area: routing forms, routing, forms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants