chore: Move pre-commit commands to pre-push#17996
Merged
Merged
Conversation
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (12/04/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/04/24)1 label was added to this PR based on Keith Williams's automation. |
PeerRich
previously approved these changes
Dec 4, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Contributor
E2E results are ready! |
emrysal
approved these changes
Dec 4, 2024
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
Looks good to me, only takes 1-2s for me which confused me a little but apparently it takes a while for others.
keithwillcode
added a commit
that referenced
this pull request
Dec 4, 2024
This reverts commit f63c06d.
keithwillcode
added a commit
that referenced
this pull request
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our commits take around 4s to complete right now. Instead of having these commands on pre-commit, we'll now have them on pre-push to improve DX.
On a side note, I noticed that all yarn commands in our monorepo have a delay of a few seconds to even startup. I moved the app-store-cli out of the monorepo as a test and running
yarn app-store:buildtakes 1.2s total instead of 4s like in the mono repo. Will continue researching that further.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
lint-stagedor in the app store build and ensure the push is blocked.